Normalize URLs in HMAC interceptor #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- and unit tests thereof - also, uncomment the HMAC debugging code (if variable GP_VERBOSE is true) Fixes: IBM-Cloud#113
srl295
commented
Jan 10, 2018
| GaasHmac.prototype.SEP = "\n"; | ||
| GaasHmac.prototype.ENC = "ascii"; // ISO-8859-1 not supported! | ||
| GaasHmac.prototype.HMAC_SHA1_ALGORITHM = 'sha1'; // "HmacSHA1"; | ||
| GaasHmac.prototype.forceDate = null; | ||
| GaasHmac.prototype.forceDateString = null; | ||
|
|
||
| // GaasHmac.prototype.VERBOSE = process.env.GP_VERBOSE || false; | ||
| GaasHmac.prototype.VERBOSE = process.env.GP_VERBOSE || false; |
There was a problem hiding this comment.
This was mostly disabled because of the lint rule, but I fixed the lint rule.
srl295
commented
Jan 10, 2018
| @@ -36,13 +38,14 @@ GaasHmac.prototype.user = undefined; | |||
| GaasHmac.prototype.secret = undefined; | |||
|
|
|||
| GaasHmac.prototype.AUTH_SCHEME = "GaaS-HMAC"; | |||
| // GaasHmac.prototype.AUTH_SCHEME = "GP-HMAC"; | |||
There was a problem hiding this comment.
we should switch the scheme in the future?
hchawla1
approved these changes
Jan 10, 2018
|
Note this is to work around swagger-api/swagger-js#1220 — could remove the around once fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #113